fix(hrms): meta.has_field for Singleton DocType guards (Wave 2 hotfix) #27

Merged

tant merged 1 commit from fix/TETRA-wave2-singleton-has-column into develop

2026-04-26 20:38:10 +07:00

tant commented

2026-04-26 20:37:53 +07:00

Owner

Singleton DocType (Vietnam HRMS Settings) lưu trong tabSingles. has_column raise TableMissingError → bench migrate fail.

Fix: replace has_column với frappe.get_meta(...).has_field(...) ở 4 callsites.

22/22 tests pass.

Refs: TETRA-1437, TETRA-1449

Singleton DocType (Vietnam HRMS Settings) lưu trong `tabSingles`. `has_column` raise TableMissingError → bench migrate fail. Fix: replace has_column với `frappe.get_meta(...).has_field(...)` ở 4 callsites. 22/22 tests pass. Refs: TETRA-1437, TETRA-1449

tant added 1 commit

2026-04-26 20:37:53 +07:00

fix(hrms): use meta.has_field for Singleton DocType guards (Wave 2 hotfix) c30c80c437

Singleton DocType (Vietnam HRMS Settings) lưu trong tabSingles không có
table tabVietnam HRMS Settings → frappe.db.has_column raise
TableMissingError. Wave 2 patches dùng has_column → bench migrate fail.

Fix: replace has_column với frappe.get_meta(doctype).has_field(fieldname)
trên cả 4 callsite:
- patches/v0_7_0/configure_sick_leave_per_policy.py
- patches/v0_7_0/seed_vietnam_hrms_settings_payment_days.py
- payroll/sick_leave_workflow.py:_get_sick_leave_policy
- setup/leave_types.py:update_sick_leave_type_per_policy

Test stub updated với _mock_get_meta — 22/22 pass.

Refs: TETRA-1437, TETRA-1449

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>