tant/vhrms
5
1
Fork 2
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(setup): Salary Structure template company-less cài được fresh install #155

Merged
tant merged 1 commit from fix/salary-structure-company-optional into main 2026-06-04 11:32:49 +07:00
Conversation 0 Commits 1 Files changed 2 +29
tant commented 2026-06-04 11:31:51 +07:00
Owner
Copy link

TETRA-1974 tạo 2 Salary Structure CHUNG ở _global_setup (after_install) khi
chưa có Company. ERPNext đặt Salary Structure.company reqd=1 → fresh install
(bench new-site --install-app vhrms) ném MandatoryError → install vỡ. Site có
sẵn Company không lộ; CI test-in-image bắt được.

  • _build_salary_structure: ignore_mandatory khi company-less (insert+submit).
  • property_setters: thêm Salary Structure.company reqd=0 (UI + migrate).
    Validated: bench new-site fresh (0 Company) cài vhrms OK, 2 SS company-less
    submitted, verification pass.
TETRA-1974 tạo 2 Salary Structure CHUNG ở _global_setup (after_install) khi chưa có Company. ERPNext đặt Salary Structure.company reqd=1 → fresh install (bench new-site --install-app vhrms) ném MandatoryError → install vỡ. Site có sẵn Company không lộ; CI test-in-image bắt được. - _build_salary_structure: ignore_mandatory khi company-less (insert+submit). - property_setters: thêm Salary Structure.company reqd=0 (UI + migrate). Validated: bench new-site fresh (0 Company) cài vhrms OK, 2 SS company-less submitted, verification pass.
fix(setup): Salary Structure template company-less cài được fresh install
All checks were successful
Test (offline) / test (push) Successful in 22s
Details
Test (offline) / test (pull_request) Successful in 29s
Details
7fa53a0d29 
TETRA-1974 tạo 2 Salary Structure CHUNG ở _global_setup (after_install) khi
chưa có Company. ERPNext đặt Salary Structure.company reqd=1 → fresh install
(bench new-site --install-app vhrms) ném MandatoryError → install vỡ. Site có
sẵn Company không lộ; CI test-in-image bắt được.

- _build_salary_structure: ignore_mandatory khi company-less (insert+submit).
- property_setters: thêm Salary Structure.company reqd=0 (UI + migrate).
Validated: bench new-site fresh (0 Company) cài vhrms OK, 2 SS company-less
submitted, verification pass.
tant merged commit bed78a8d65 into main 2026-06-04 11:32:49 +07:00
tant deleted branch fix/salary-structure-company-optional 2026-06-04 11:32:49 +07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tant/vhrms!155
No description provided.